Remove confusing job!="" filteringSelector when no selector is required. #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v-zhuravlev
force-pushed
the
no_filteringSelector
branch
from
97d2fe7 to
b8ffd20
Compare
v-zhuravlev
force-pushed
the
no_filteringSelector
branch
from
6b10482 to
39af36a
Compare
|
To pass tests, we need to merge #1372 separately, then rebase here. |
Dasomeone
reviewed
Dec 11, 2024
| @@ -13,6 +13,11 @@ local utils = import '../utils.libsonnet'; | |||
| prometheusDatasourceName=if enableLokiLogs then 'prometheus_datasource' else 'datasource', | |||
| prometheusDatasourceLabel=if enableLokiLogs then 'Prometheus data source' else 'Data source', | |||
| ): { | |||
| // strip trailing or starting comma if present: | |||
| // while trailing comman is accepted in PromQL expressions, starting comma is not. | |||
There was a problem hiding this comment.
Typo fix suggestion in dependency PR
There was a problem hiding this comment.
should be fixed by merge.
Dasomeone
approved these changes
Dec 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
since filteringSelector is now optional (can be set to ""),
remove confusing job!="" filteringSelector when no selector is required,
from some mixins/libs:
This should help with mixins rendered on
monitoring-mixin website:
https://monitoring.mixins.dev/jvm/